gh-130821: Add type info to error messages for __len__ and __sizeof__#151894
Closed
tangyuan0821 wants to merge 2 commits into
Closed
gh-130821: Add type info to error messages for __len__ and __sizeof__#151894tangyuan0821 wants to merge 2 commits into
tangyuan0821 wants to merge 2 commits into
Conversation
tangyuan0821
requested review from
ericsnowcurrently and
markshannon
as code owners
Member
|
Hello @tangyuan0821 the other PR you noted, #144827, is still open, I think these could just be added to it? In the future, I suggest reviews on open PRs, rather than opening new ones for these kinds of things. |
Contributor
Author
|
@StanFromIreland Thanks for the suggestion! I didn't notice that #144827 was still open. I'll close this PR now, and next time I'll make sure to review existing PRs first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update two more ValueError messages to use the consistent format established in PR #130835 (commit 968f6e5), which added %T type prefix and normalized should → must for invalid return type errors. These two locations were not covered by the original PR or the subsequent follow-ups #144827 and #144737.
Changes: